“Is ‘don’t act on those desires’ good advice?”

Not even a little bit.  The problem is there is no such thing as actual homosexual desires, they are a mixture of fundamental same-sex needs and erotic desires.  Placing erotic desires on hold is great advice, but presenting the fore-gone conclusion that the same-sex needs and erotic desires are one in the same is speaking not from truth but from assumptions or from indoctrination from the gay lobby.  Biblical advice is we need to encourage men to get their legit same-sex needs met.  To do that we need to 1) use a metaphorical scalpel to separate what’s erotic and what’s not, and then 2) encourage them to be proactive and assertive in asking other men to help them meet their same-sex needs – from many men, not just one.  They will not change if their same-sex needs are not met in healthy non-erotic ways.  “Father’s, if you do not kiss your son, another man will.” – Richard Cohen.  If you successfully shut him down entirely, without separating what’s erotic and what’s not, you will have literally broken his masculine heart, and he will have a much more difficult time in therapy.